Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: Source/core/rendering/RenderWidget.h

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revised method for widget lifetime management. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderWidget.h
diff --git a/Source/core/rendering/RenderWidget.h b/Source/core/rendering/RenderWidget.h
index b9ed0f9c4aae2eb13369dd1abe95c9de90ff9278..4f7c9ef8994dcfc1991e4e47a45a189a59941fb9 100644
--- a/Source/core/rendering/RenderWidget.h
+++ b/Source/core/rendering/RenderWidget.h
@@ -31,8 +31,9 @@ class RenderWidget : public RenderReplaced {
public:
virtual ~RenderWidget();
- Widget* widget() const { return m_widget.get(); }
- virtual void setWidget(PassRefPtr<Widget>);
+ Widget* widget() const;
+ virtual void attachWidget(Widget*);
+ virtual void detachWidget(Widget*);
void updateWidgetPosition();
void widgetPositionsUpdated();
@@ -54,8 +55,6 @@ protected:
FrameView* frameView() const { return m_frameView; }
- void clearWidget();
-
virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) OVERRIDE FINAL;
virtual void layout();
virtual void paint(PaintInfo&, const LayoutPoint&);
@@ -73,7 +72,6 @@ private:
bool setWidgetGeometry(const LayoutRect&);
bool updateWidgetGeometry();
- RefPtr<Widget> m_widget;
FrameView* m_frameView;
IntRect m_clipRect; // The rectangle needs to remain correct after scrolling, so it is stored in content view coordinates, and not clipped to window.
int m_refCount;

Powered by Google App Engine
This is Rietveld 408576698