Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: Source/core/rendering/RenderPart.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revised method for widget lifetime management. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderPart.cpp
diff --git a/Source/core/rendering/RenderPart.cpp b/Source/core/rendering/RenderPart.cpp
index 33db879892691d68b3f0ce64515ea8630b8b1be1..8fbdb45bb1db356b9068a386d89caad7e02058a7 100644
--- a/Source/core/rendering/RenderPart.cpp
+++ b/Source/core/rendering/RenderPart.cpp
@@ -45,18 +45,17 @@ RenderPart::RenderPart(Element* node)
RenderPart::~RenderPart()
{
- clearWidget();
}
-void RenderPart::setWidget(PassRefPtr<Widget> widget)
+void RenderPart::attachWidget(Widget* widget)
{
- if (widget == this->widget())
- return;
-
- RenderWidget::setWidget(widget);
+ RenderWidget::attachWidget(widget);
+ viewCleared();
+}
- // make sure the scrollbars are set correctly for restore
- // ### find better fix
+void RenderPart::detachWidget(Widget* widget)
+{
+ RenderWidget::detachWidget(widget);
viewCleared();
}

Powered by Google App Engine
This is Rietveld 408576698