BrowserPlugin/WebView - Move plugin lifetime to DOM

Source/core/html/HTMLObjectElement.cpp

Index: Source/core/html/HTMLObjectElement.cpp
diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp
index e6f66a85f54d830dfe1570869cbf558b2cd01d3e..96bb16c09775b9d480cae9ca45cb9d09cb8792d3 100644
--- a/Source/core/html/HTMLObjectElement.cpp
+++ b/Source/core/html/HTMLObjectElement.cpp
@@ -96,8 +96,9 @@ void HTMLObjectElement::parseAttribute(const QualifiedName& name, const AtomicSt
         size_t pos = m_serviceType.find(";");
         if (pos != kNotFound)
             m_serviceType = m_serviceType.left(pos);
-        if (renderer())
-            setNeedsWidgetUpdate(true);
+        // We'll always indicate we need an update, in case a plugin wants to
+        // be created based on the service type.
+        setNeedsWidgetUpdate(true);

[eseidel, 2013/12/02 16:28:34]

But we don't have the data yet, do we?

[wjmaclean, 2013/12/02 21:51:55]

No, but we can check when we run the widget update code.

     } else if (name == dataAttr) {
         m_url = stripLeadingAndTrailingHTMLSpaces(value);
         if (renderer()) {
@@ -491,7 +492,7 @@ bool HTMLObjectElement::appendFormData(FormDataList& encoding, bool)
     if (name().isEmpty())
         return false;
 
-    Widget* widget = pluginWidget();
+    Widget* widget = this->widget();
     if (!widget || !widget->isPluginView())
         return false;
     String value;