BrowserPlugin/WebView - Move plugin lifetime to DOM

Source/core/html/HTMLObjectElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Stefan Schimanski (1Stein@gmx.de)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 78 matching lines @@
 
 void HTMLObjectElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
     if (name == formAttr)
         formAttributeChanged();
     else if (name == typeAttr) {
         m_serviceType = value.lower();
         size_t pos = m_serviceType.find(";");
         if (pos != kNotFound)
             m_serviceType = m_serviceType.left(pos);
-        if (renderer())
-            setNeedsWidgetUpdate(true);
+        // We'll always indicate we need an update, in case a plugin wants to
+        // be created based on the service type.
+        setNeedsWidgetUpdate(true);

[eseidel, 2013/12/02 16:28:34]

But we don't have the data yet, do we?

[wjmaclean, 2013/12/02 21:51:55]

No, but we can check when we run the widget update code.

     } else if (name == dataAttr) {
         m_url = stripLeadingAndTrailingHTMLSpaces(value);
         if (renderer()) {
             setNeedsWidgetUpdate(true);
             if (isImageType()) {
                 if (!m_imageLoader)
                     m_imageLoader = adoptPtr(new HTMLImageLoader(this));
                 m_imageLoader->updateFromElementIgnoringPreviousError();
             }
         }
@@ skipping 373 matching lines @@
 {
     FormAssociatedElement::didMoveToNewDocument(oldDocument);
     HTMLPlugInElement::didMoveToNewDocument(oldDocument);
 }
 
 bool HTMLObjectElement::appendFormData(FormDataList& encoding, bool)
 {
     if (name().isEmpty())
         return false;
 
-    Widget* widget = pluginWidget();
+    Widget* widget = this->widget();
     if (!widget || !widget->isPluginView())
         return false;
     String value;
     if (!toPluginView(widget)->getFormValue(value))
         return false;
     encoding.appendData(name(), value);
     return true;
 }
 
 HTMLFormElement* HTMLObjectElement::virtualForm() const
 {
     return FormAssociatedElement::form();
 }
 
 bool HTMLObjectElement::isInteractiveContent() const
 {
     return fastHasAttribute(usemapAttr);
 }
 
 }