Source/core/rendering/RenderWidget.h - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderWidget.h

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Don't store plugin (widget) pointer in RenderWidget. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderWidget.h

diff --git a/Source/core/rendering/RenderWidget.h b/Source/core/rendering/RenderWidget.h

index b9ed0f9c4aae2eb13369dd1abe95c9de90ff9278..fe5065ea9b23aaf9921b040ddefa258c03e229c3 100644

--- a/Source/core/rendering/RenderWidget.h

+++ b/Source/core/rendering/RenderWidget.h

@@ -29,10 +29,12 @@ namespace WebCore {

class RenderWidget : public RenderReplaced {

public:

+ enum ConfigureType { ConfigureOnAttach, ConfigureOnDetach };

virtual ~RenderWidget();

- Widget* widget() const { return m_widget.get(); }

+ Widget* widget() const;

virtual void setWidget(PassRefPtr<Widget>);

+ virtual void configureWidget(ConfigureType);

void updateWidgetPosition();

void widgetPositionsUpdated();