Source/core/loader/EmptyClients.h - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/EmptyClients.h

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Don't store plugin (widget) pointer in RenderWidget. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/EmptyClients.h

diff --git a/Source/core/loader/EmptyClients.h b/Source/core/loader/EmptyClients.h

index 48c24ae4630e50699f7cb6a73e996aa724c51f85..dc07a6e6fbfb642db1675c61cece9326f066a344 100644

--- a/Source/core/loader/EmptyClients.h

+++ b/Source/core/loader/EmptyClients.h

@@ -233,7 +233,8 @@ public:

virtual void didDispatchPingLoader(const KURL&) OVERRIDE { }

virtual void selectorMatchChanged(const Vector<String>&, const Vector<String>&) OVERRIDE { }

virtual PassRefPtr<Frame> createFrame(const KURL&, const String&, const String&, HTMLFrameOwnerElement*) OVERRIDE;

- virtual PassRefPtr<Widget> createPlugin(const IntSize&, HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool) OVERRIDE;

+ virtual bool canCreatePluginWithoutRenderer(const String& mimeType) const OVERRIDE { return false; }

+ virtual PassRefPtr<Widget> createPlugin(const IntSize&, HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool, bool = false) OVERRIDE;

eseidel 2013/11/18 22:26:45 Bools as arguments are sad-panda. Enums are much

wjmaclean 2013/11/25 17:51:56 Sad-panda happy now ... fixed. :-)

virtual PassRefPtr<Widget> createJavaAppletWidget(const IntSize&, HTMLAppletElement*, const KURL&, const Vector<String>&, const Vector<String>&) OVERRIDE;

virtual ObjectContentType objectContentType(const KURL&, const String&, bool) OVERRIDE { return ObjectContentType(); }

« Source/core/html/HTMLPlugInElement.cpp ('K') | « Source/core/html/HTMLPlugInElement.cpp ('k') | Source/core/loader/EmptyClients.cpp » ('j') | Source/core/rendering/RenderWidget.cpp » ('J')