Source/core/loader/FrameLoaderClient.h - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoaderClient.h

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Don't store plugin (widget) pointer in RenderWidget. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/FrameLoaderClient.h

diff --git a/Source/core/loader/FrameLoaderClient.h b/Source/core/loader/FrameLoaderClient.h

index 6321b6879457333cf2f0636bdeecf155892c6392..549af12760849a12d5f491b5f528c7a7da3a5d8a 100644

--- a/Source/core/loader/FrameLoaderClient.h

+++ b/Source/core/loader/FrameLoaderClient.h

@@ -168,7 +168,8 @@ class FetchRequest;

virtual void transitionToCommittedForNewPage() = 0;

virtual PassRefPtr<Frame> createFrame(const KURL&, const String& name, const String& referrer, HTMLFrameOwnerElement*) = 0;

- virtual PassRefPtr<Widget> createPlugin(const IntSize&, HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool loadManually) = 0;

+ virtual bool canCreatePluginWithoutRenderer(const String& mimeType) const = 0;

+ virtual PassRefPtr<Widget> createPlugin(const IntSize&, HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool loadManually, bool loadWithoutRenderer = false) = 0;

virtual PassRefPtr<Widget> createJavaAppletWidget(const IntSize&, HTMLAppletElement*, const KURL& baseURL, const Vector<String>& paramNames, const Vector<String>& paramValues) = 0;

« Source/core/loader/EmptyClients.h ('K') | « Source/core/loader/EmptyClients.cpp ('k') | Source/core/rendering/RenderPart.h » ('j') | Source/core/rendering/RenderWidget.cpp » ('J')