Source/core/frame/FrameView.cpp - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1056)

My Issues | Starred Open | Closed | All

Unified Diff: Source/core/frame/FrameView.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Handle shared-renderer case. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/FrameView.cpp

diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp

index ada21e0cbe30181290d227c3d938e713122be54c..35c1db9241d67355d0c58d090082f7bc8a46b473 100644

--- a/Source/core/frame/FrameView.cpp

+++ b/Source/core/frame/FrameView.cpp

@@ -205,9 +205,9 @@ FrameView::~FrameView()

ASSERT(m_frame);

ASSERT(m_frame->view() != this || !m_frame->contentRenderer());

- RenderPart* renderer = m_frame->ownerRenderer();

- if (renderer && renderer->widget() == this)

- renderer->setWidget(nullptr);

+ HTMLFrameOwnerElement* ownerElement = m_frame->ownerElement();

+ if (ownerElement && ownerElement->ownedWidget() == this)

+ ownerElement->setWidget(nullptr);

}

void FrameView::reset()

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698