Source/core/dom/Element.cpp - Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(604)

My Issues | Starred Open | Closed | All

Unified Diff: Source/core/dom/Element.cpp

Issue 23618022: BrowserPlugin/WebView - Move plugin lifetime to DOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Handle shared-renderer case. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 5e253134f885f131f115022eb381418201ea169f..2983f41dbe741f4a1b151734ca8f62d6e017dc3c 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -96,7 +96,6 @@

#include "core/page/PointerLockController.h"

#include "core/rendering/RenderLayer.h"

#include "core/rendering/RenderView.h"

-#include "core/rendering/RenderWidget.h"

#include "core/svg/SVGDocumentExtensions.h"

#include "core/svg/SVGElement.h"

#include "platform/scroll/ScrollableArea.h"

@@ -1414,7 +1413,7 @@ void Element::attach(const AttachContext& context)

void Element::detach(const AttachContext& context)

{

- RenderWidget::UpdateSuspendScope suspendWidgetHierarchyUpdates;

+ HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;

cancelFocusAppearanceUpdate();

removeCallbackSelectors();

if (needsLayerUpdate())

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698