Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2361793002: [compiler] Bump --max-inlined-nodes default to 200. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Bump --max-inlined-nodes default to 200. R=jarin@chromium.org Committed: https://crrev.com/a0fb619621cf89b15e2a84b1089369daa780bde0 Cr-Commit-Position: refs/heads/master@{#39622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2361813002 Patch 1

Messages

Total messages: 14 (6 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-22 10:25:56 UTC) #1
Benedikt Meurer
Hey Jaro, As discussed offline. Please take a look. Thanks, Benedikt
4 years, 3 months ago (2016-09-22 10:26:33 UTC) #4
Jarin
lgtm
4 years, 3 months ago (2016-09-22 10:27:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361793002/1
4 years, 3 months ago (2016-09-22 10:55:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 10:57:23 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a0fb619621cf89b15e2a84b1089369daa780bde0 Cr-Commit-Position: refs/heads/master@{#39622}
4 years, 3 months ago (2016-09-22 10:58:18 UTC) #12
Michael Hablich
Could you please elaborate why you are bumping the number?
4 years, 3 months ago (2016-09-22 12:43:18 UTC) #13
Benedikt Meurer
4 years, 3 months ago (2016-09-23 11:51:19 UTC) #14
Message was sent while issue was closed. 
The previous 196 was abitrary and probably tweaked for some specific benchmark
in some distant past. We couldn't find any reason today why this should be 196.
We bumped it to 200 as that's required for Octane/NavierStokes to inline the
hottest function (lin_solve).

Powered by Google App Engine
This is Rietveld 408576698