Remove some objnum locals with AddIndirectObject

Remove some objnum locals with AddIndirectObject

Also, it's idempotent, so simplify some logic in callers to
not care if objnum is zero.

The alternate forms are rarely used, using the objnum form
makes it clear that SetReferenceFor() can't possibly register 
the object as a side-effect.

Committed: https://pdfium.googlesource.com/pdfium/+/bb577af2f17467a55c04fbff21a8f0ec1016601a

[Tom Sepez, 2016-09-22 00:07:47]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-09-22 00:07:47]

Dan, mindless tweaking.  I think it reads better this way.

[Tom Sepez, 2016-09-22 00:08:00]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 00:08:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 00:15:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 00:15:55]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-22 00:22:58]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 00:23:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-22 00:31:59]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 00:32:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-22 00:33:27]

Description was changed from

==========
Remove some objnum locals with AddIndirectObject

Also, it's idempotent, so simplify some logic in callers to
not care if objnum is zero.
==========

to

==========
Remove some objnum locals with AddIndirectObject

Also, it's idempotent, so simplify some logic in callers to
not care if objnum is zero.

The alternate forms are rarely used, using the objnum form
makes it clear that SetReferenceFor() can't possibly register 
the object as a side-effect.
==========

[commit-bot: I haz the power, 2016-09-22 00:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 00:47:52]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-22 02:09:56]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-22 02:09:56]

lgtm

[commit-bot: I haz the power, 2016-09-22 02:09:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 02:10:22]

Description was changed from

==========
Remove some objnum locals with AddIndirectObject

Also, it's idempotent, so simplify some logic in callers to
not care if objnum is zero.

The alternate forms are rarely used, using the objnum form
makes it clear that SetReferenceFor() can't possibly register 
the object as a side-effect.
==========

to

==========
Remove some objnum locals with AddIndirectObject

Also, it's idempotent, so simplify some logic in callers to
not care if objnum is zero.

The alternate forms are rarely used, using the objnum form
makes it clear that SetReferenceFor() can't possibly register 
the object as a side-effect.

Committed:
https://pdfium.googlesource.com/pdfium/+/bb577af2f17467a55c04fbff21a8f0ec1016...
==========

[commit-bot: I haz the power, 2016-09-22 02:10:23]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/bb577af2f17467a55c04fbff21a8f0ec1016...