core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp - Issue 2361713002: Remove some objnum locals with AddIndirectObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

Issue 2361713002: Remove some objnum locals with AddIndirectObject (Closed)

Patch Set: Same treatment for arrays Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp b/core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

index cbfdf2b9aca9530c2c15508dd29bd10748b6615e..dad98cd28e5e95415371bef3ac1e01187c733505 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

@@ -730,7 +730,7 @@ TEST(PDFArrayTest, AddReferenceAndGetObjectAt) {

holder->ReplaceIndirectObjectIfHigherGeneration(obj_nums[i],

indirect_objs[i]);

arr->AddReference(holder.get(), obj_nums[i]);

- arr1->AddReference(holder.get(), indirect_objs[i]);

+ arr1->AddReference(holder.get(), indirect_objs[i]->GetObjNum());

}

// Check indirect objects.

for (size_t i = 0; i < FX_ArraySize(obj_nums); ++i)