Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2361683002: Don't round the paint offset when painting carets. (Closed)

Created:
4 years, 3 months ago by chrishtr
Modified:
4 years, 3 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't round the paint offset when painting carets. BUG=645446 Committed: https://crrev.com/5d6d94d276b2bd5620397366bdc339c88651e3c9 Cr-Commit-Position: refs/heads/master@{#420363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
chrishtr
I missed this in https://codereview.chromium.org/2310173002.
4 years, 3 months ago (2016-09-22 14:51:36 UTC) #7
Xianzhu
lgtm
4 years, 3 months ago (2016-09-22 16:07:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361683002/1
4 years, 3 months ago (2016-09-22 16:08:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 16:13:43 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 16:16:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d6d94d276b2bd5620397366bdc339c88651e3c9
Cr-Commit-Position: refs/heads/master@{#420363}

Powered by Google App Engine
This is Rietveld 408576698