Paint carets at pixel-snapped positions.

Paint carets at pixel-snapped positions.

BUG=640463
Committed: https://crrev.com/15cd2c4febc289ac3291ad1613841f6efaa610a6
Cr-Commit-Position: refs/heads/master@{#416741}

[chrishtr, 2016-09-06 18:31:10]

Description was changed from

==========
none


none

BUG=
==========

to

==========
Paint carets at pixel-snapped positions.

BUG=640463
==========

[chrishtr, 2016-09-06 18:31:17]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-09-06 18:42:27]

https://codereview.chromium.org/2310173002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/paint/caret/caret-subpixel.html (right):

https://codereview.chromium.org/2310173002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/caret/caret-subpixel.html:5: onload = () =>
target.focus();
Better to also test paint invalidation to ensure we invalidate and paint at the
same place for the caret. You may need to disable the focus ring to avoid the
paint invalidation of focus ring change so that the only paint invalidation is
for the caret.

[chrishtr, 2016-09-06 19:00:38]

https://codereview.chromium.org/2310173002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/paint/caret/caret-subpixel.html (right):

https://codereview.chromium.org/2310173002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/caret/caret-subpixel.html:5: onload = () =>
target.focus();
On 2016/09/06 at 18:42:27, Xianzhu wrote:
> Better to also test paint invalidation to ensure we invalidate and paint at
the same place for the caret. You may need to disable the focus ring to avoid
the paint invalidation of focus ring change so that the only paint invalidation
is for the caret.

Done.

[Xianzhu, 2016-09-06 19:06:47]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-06 19:06:48]

lgtm

[commit-bot: I haz the power, 2016-09-06 19:07:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 20:39:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 20:39:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-09-06 21:27:53]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-06 21:27:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2310173002/#ps60001
(title: "none")

[commit-bot: I haz the power, 2016-09-06 21:28:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 22:55:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-06 22:58:15]

Description was changed from

==========
Paint carets at pixel-snapped positions.

BUG=640463
==========

to

==========
Paint carets at pixel-snapped positions.

BUG=640463

Committed: https://crrev.com/15cd2c4febc289ac3291ad1613841f6efaa610a6
Cr-Commit-Position: refs/heads/master@{#416741}
==========

[commit-bot: I haz the power, 2016-09-06 22:58:16]

Patchset 4 (id:??) landed as
https://crrev.com/15cd2c4febc289ac3291ad1613841f6efaa610a6
Cr-Commit-Position: refs/heads/master@{#416741}