content/browser/service_worker/service_worker_internals_ui.cc - Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_internals_ui.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)

Patch Set: make device hosts profile-independent, plump browser context for inspect. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_internals_ui.cc

diff --git a/content/browser/service_worker/service_worker_internals_ui.cc b/content/browser/service_worker/service_worker_internals_ui.cc

index ed8ddda2f5ea9f77c094a2955bd79b824033dd2b..46404e75603579382a4b5babf018feecec0c1f69 100644

--- a/content/browser/service_worker/service_worker_internals_ui.cc

+++ b/content/browser/service_worker/service_worker_internals_ui.cc

@@ -543,7 +543,7 @@ void ServiceWorkerInternalsUI::InspectWorker(const ListValue* args) {

callback.Run(SERVICE_WORKER_ERROR_NOT_FOUND);

return;

}

- agent_host->Inspect();

+ agent_host->Inspect(nullptr);

callback.Run(SERVICE_WORKER_OK);

}