content/browser/devtools/render_frame_devtools_agent_host.cc - Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)

Patch Set: make device hosts profile-independent, plump browser context for inspect. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/render_frame_devtools_agent_host.cc

diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc

index c2d13d65aa25319b23562ad25c325714aa6ad509..e62323c2f7435dca3b4b49d239834193e6f77eb3 100644

--- a/content/browser/devtools/render_frame_devtools_agent_host.cc

+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc

@@ -1015,7 +1015,7 @@ void RenderFrameDevToolsAgentHost::OnRequestNewWindow(

if (IsAttached() && sender->GetRoutingID() != new_routing_id && frame_host) {

scoped_refptr<DevToolsAgentHost> agent =

DevToolsAgentHost::GetOrCreateFor(frame_host);

- success = agent->Inspect();

+ success = agent->Inspect(nullptr);

}

sender->Send(new DevToolsAgentMsg_RequestNewWindow_ACK(