Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4603)

Unified Diff: chrome/browser/devtools/devtools_targets_ui.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)
Patch Set: make device hosts profile-independent, plump browser context for inspect. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_targets_ui.cc
diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc
index d5e0a3d383edf6be51767d91354bef27c7a2b04b..300848ea7f576675700aabba08003c5687bf674b 100644
--- a/chrome/browser/devtools/devtools_targets_ui.cc
+++ b/chrome/browser/devtools/devtools_targets_ui.cc
@@ -65,7 +65,6 @@ const char kAdbPagesList[] = "pages";
const char kAdbScreenWidthField[] = "adbScreenWidth";
const char kAdbScreenHeightField[] = "adbScreenHeight";
-const char kAdbAttachedForeignField[] = "adbAttachedForeign";
const char kPortForwardingPorts[] = "ports";
const char kPortForwardingBrowserId[] = "browserId";
@@ -370,13 +369,8 @@ void AdbTargetsUIHandler::DeviceListChanged(
remote_browsers_[browser_id] = browser;
browser_data->Set(kAdbPagesList, page_list);
for (const auto& page : browser->pages()) {
- scoped_refptr<DevToolsAgentHost> host =
- android_bridge_->CreatePageTarget(page);
+ scoped_refptr<DevToolsAgentHost> host = page->CreateTarget();
std::unique_ptr<base::DictionaryValue> target_data = Serialize(host);
- target_data->SetBoolean(
- kAdbAttachedForeignField,
- host->IsAttached() &&
- !android_bridge_->HasDevToolsWindow(host->GetId()));
// Pass the screen size in the target object to make sure that
// the caching logic does not prevent the target item from updating
// when the screen size changes.

Powered by Google App Engine
This is Rietveld 408576698