chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc - Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)

Patch Set: make device hosts profile-independent, plump browser context for inspect. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/devtools_manager_delegate_android.cc ('K') | « chrome/browser/devtools/chrome_devtools_manager_delegate.cc ('k') | chrome/browser/devtools/device/devtools_android_bridge.h » ('j') | chrome/browser/devtools/device/devtools_android_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

diff --git a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

index d2c6c570ec9cf23adce6848f1e3e2cace882a566..2cd479316980e7313b5770946030aaf7f49d35b8 100644

--- a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

+++ b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

@@ -108,13 +108,13 @@ class AdbClientSocketTest : public InProcessBrowserTest,

ASSERT_EQ(2U, webview_pages.size());

scoped_refptr<content::DevToolsAgentHost> chrome_target(

- android_bridge_->CreatePageTarget(chrome_pages[0]));

+ chrome_pages[0]->CreateTarget());

scoped_refptr<content::DevToolsAgentHost> chrome_beta_target(

- android_bridge_->CreatePageTarget(chrome_beta_pages[0]));

+ chrome_beta_pages[0]->CreateTarget());

scoped_refptr<content::DevToolsAgentHost> webview_target_0(

- android_bridge_->CreatePageTarget(webview_pages[0]));

+ webview_pages[0]->CreateTarget());

scoped_refptr<content::DevToolsAgentHost> webview_target_1(

- android_bridge_->CreatePageTarget(webview_pages[1]));

+ webview_pages[1]->CreateTarget());

// Check that we have non-empty description for webview pages.

ASSERT_EQ(0U, chrome_target->GetDescription().size());