Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)
Patch Set: make device hosts profile-independent, plump browser context for inspect. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/device/adb/adb_device_provider.h" 5 #include "chrome/browser/devtools/device/adb/adb_device_provider.h"
6 #include "chrome/browser/devtools/device/adb/mock_adb_server.h" 6 #include "chrome/browser/devtools/device/adb/mock_adb_server.h"
7 #include "chrome/browser/devtools/device/devtools_android_bridge.h" 7 #include "chrome/browser/devtools/device/devtools_android_bridge.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/test/base/in_process_browser_test.h" 9 #include "chrome/test/base/in_process_browser_test.h"
10 #include "content/public/browser/browser_thread.h" 10 #include "content/public/browser/browser_thread.h"
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 DevToolsAndroidBridge::RemotePages chrome_beta_pages = 101 DevToolsAndroidBridge::RemotePages chrome_beta_pages =
102 chrome_beta->pages(); 102 chrome_beta->pages();
103 DevToolsAndroidBridge::RemotePages webview_pages = 103 DevToolsAndroidBridge::RemotePages webview_pages =
104 webview->pages(); 104 webview->pages();
105 105
106 ASSERT_EQ(1U, chrome_pages.size()); 106 ASSERT_EQ(1U, chrome_pages.size());
107 ASSERT_EQ(1U, chrome_beta_pages.size()); 107 ASSERT_EQ(1U, chrome_beta_pages.size());
108 ASSERT_EQ(2U, webview_pages.size()); 108 ASSERT_EQ(2U, webview_pages.size());
109 109
110 scoped_refptr<content::DevToolsAgentHost> chrome_target( 110 scoped_refptr<content::DevToolsAgentHost> chrome_target(
111 android_bridge_->CreatePageTarget(chrome_pages[0])); 111 chrome_pages[0]->CreateTarget());
112 scoped_refptr<content::DevToolsAgentHost> chrome_beta_target( 112 scoped_refptr<content::DevToolsAgentHost> chrome_beta_target(
113 android_bridge_->CreatePageTarget(chrome_beta_pages[0])); 113 chrome_beta_pages[0]->CreateTarget());
114 scoped_refptr<content::DevToolsAgentHost> webview_target_0( 114 scoped_refptr<content::DevToolsAgentHost> webview_target_0(
115 android_bridge_->CreatePageTarget(webview_pages[0])); 115 webview_pages[0]->CreateTarget());
116 scoped_refptr<content::DevToolsAgentHost> webview_target_1( 116 scoped_refptr<content::DevToolsAgentHost> webview_target_1(
117 android_bridge_->CreatePageTarget(webview_pages[1])); 117 webview_pages[1]->CreateTarget());
118 118
119 // Check that we have non-empty description for webview pages. 119 // Check that we have non-empty description for webview pages.
120 ASSERT_EQ(0U, chrome_target->GetDescription().size()); 120 ASSERT_EQ(0U, chrome_target->GetDescription().size());
121 ASSERT_EQ(0U, chrome_beta_target->GetDescription().size()); 121 ASSERT_EQ(0U, chrome_beta_target->GetDescription().size());
122 ASSERT_NE(0U, webview_target_0->GetDescription().size()); 122 ASSERT_NE(0U, webview_target_0->GetDescription().size());
123 ASSERT_NE(0U, webview_target_1->GetDescription().size()); 123 ASSERT_NE(0U, webview_target_1->GetDescription().size());
124 124
125 ASSERT_EQ(GURL("http://www.chromium.org/"), 125 ASSERT_EQ(GURL("http://www.chromium.org/"),
126 chrome_target->GetURL()); 126 chrome_target->GetURL());
127 ASSERT_EQ("The Chromium Projects", 127 ASSERT_EQ("The Chromium Projects",
(...skipping 21 matching lines...) Expand all
149 StopMockAdbServer(); 149 StopMockAdbServer();
150 } 150 }
151 151
152 // Flaky due to failure to bind a hardcoded port. crbug.com/566057 152 // Flaky due to failure to bind a hardcoded port. crbug.com/566057
153 IN_PROC_BROWSER_TEST_F(AdbClientSocketTest, DISABLED_TestFlushWithData) { 153 IN_PROC_BROWSER_TEST_F(AdbClientSocketTest, DISABLED_TestFlushWithData) {
154 StartMockAdbServer(FlushWithData); 154 StartMockAdbServer(FlushWithData);
155 StartTest(); 155 StartTest();
156 CheckDevices(); 156 CheckDevices();
157 StopMockAdbServer(); 157 StopMockAdbServer();
158 } 158 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698