Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/android/devtools_manager_delegate_android.cc

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)
Patch Set: make device hosts profile-independent, plump browser context for inspect. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/devtools_manager_delegate_android.cc
diff --git a/chrome/browser/android/devtools_manager_delegate_android.cc b/chrome/browser/android/devtools_manager_delegate_android.cc
index 6b7f24c272239d25b7d65f629fb7b06990fa7ca1..2375084341352d54ed80e9c5a8855a5c10b05a5e 100644
--- a/chrome/browser/android/devtools_manager_delegate_android.cc
+++ b/chrome/browser/android/devtools_manager_delegate_android.cc
@@ -94,10 +94,10 @@ class TabProxyDelegate : public content::DevToolsExternalAgentProxyDelegate,
return true;
}
- bool Inspect() override {
+ bool Inspect(content::BrowserContext* context) override {
MaterializeAgentHost();
if (agent_host_)
- return agent_host_->Inspect();
+ return agent_host_->Inspect(context);
dgozman 2016/09/22 17:13:59 It's strange to pass BrowserContext in just so tha
return false;
}
@@ -168,10 +168,6 @@ DevToolsManagerDelegateAndroid::DevToolsManagerDelegateAndroid()
DevToolsManagerDelegateAndroid::~DevToolsManagerDelegateAndroid() {
}
-void DevToolsManagerDelegateAndroid::Inspect(
- DevToolsAgentHost* agent_host) {
-}
-
base::DictionaryValue* DevToolsManagerDelegateAndroid::HandleCommand(
DevToolsAgentHost* agent_host,
base::DictionaryValue* command_dict) {

Powered by Google App Engine
This is Rietveld 408576698