Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 2361593002: [modules] Do path resolution relative to each module file in d8 (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Do path resolution relative to each module file in d8 BUG=v8:1569 Committed: https://crrev.com/3bbd11c23390243a237158af4a01358497958b5b Cr-Commit-Position: refs/heads/master@{#39646}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Add cctest, try to fix windows build #

Patch Set 4 : PathIsRelative #

Patch Set 5 : More attempts to fix build #

Patch Set 6 : More windows buld fixes #

Patch Set 7 : Move stuff around #

Patch Set 8 : Windows #

Patch Set 9 : Windows #

Patch Set 10 : Windows #

Patch Set 11 : Windows #

Patch Set 12 : No more PathIsRelative #

Patch Set 13 : Add some dumb absolute path logic on Windows #

Patch Set 14 : No first_slash #

Patch Set 15 : Look for backslashes #

Total comments: 12

Patch Set 16 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -33 lines) Patch
M include/v8.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/d8.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +82 lines, -25 lines 0 comments Download
M src/factory.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-printer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-modules.cc View 1 2 3 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 37 (29 generated)
adamk
Okay, this is ready for review
4 years, 3 months ago (2016-09-21 22:50:34 UTC) #11
adamk
+neis
4 years, 3 months ago (2016-09-21 22:50:45 UTC) #13
neis
Thanks! Some comments below. Will have another look tomorrow. https://codereview.chromium.org/2361593002/diff/280001/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/2361593002/diff/280001/src/d8.cc#newcode524 src/d8.cc:524: ...
4 years, 3 months ago (2016-09-22 01:07:39 UTC) #26
adamk
https://codereview.chromium.org/2361593002/diff/280001/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/2361593002/diff/280001/src/d8.cc#newcode524 src/d8.cc:524: #else On 2016/09/22 01:07:39, neis wrote: > I don't ...
4 years, 3 months ago (2016-09-22 19:06:57 UTC) #28
neis
lgtm
4 years, 3 months ago (2016-09-22 21:00:30 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361593002/300001
4 years, 3 months ago (2016-09-22 21:01:07 UTC) #34
commit-bot: I haz the power
Committed patchset #16 (id:300001)
4 years, 3 months ago (2016-09-22 21:03:26 UTC) #35
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 21:03:53 UTC) #37
Message was sent while issue was closed.
Patchset 16 (id:??) landed as
https://crrev.com/3bbd11c23390243a237158af4a01358497958b5b
Cr-Commit-Position: refs/heads/master@{#39646}

Powered by Google App Engine
This is Rietveld 408576698