src/factory.cc - Issue 2361593002: [modules] Do path resolution relative to each module file in d8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 2361593002: [modules] Do path resolution relative to each module file in d8 (Closed)

Patch Set: Review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 0abf9ad217938b23a89d1f6c9fbba09e7d54c48b..26b76ee7db91e92234172d3601c4920c027aecfe 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1764,6 +1764,7 @@ Handle<Module> Factory::NewModule(Handle<SharedFunctionInfo> code) {

module->set_exports(*exports);

module->set_requested_modules(*requested_modules);

module->set_flags(0);

+ module->set_embedder_data(isolate()->heap()->undefined_value());

return module;

}

« no previous file with comments | « src/d8.cc ('k') | src/objects.h » ('j') | no next file with comments »