Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: content/common/nav_controller_messages.h

Issue 23615009: Stub out initial NavigationController browser implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comments, s/peer/registry/ now that blink side is settled Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/nav_controller_messages.h
diff --git a/content/common/nav_controller_messages.h b/content/common/nav_controller_messages.h
new file mode 100644
index 0000000000000000000000000000000000000000..a9c29f1bb8b4611dd66fa269cc1b8d8ae59eb7ff
--- /dev/null
+++ b/content/common/nav_controller_messages.h
@@ -0,0 +1,27 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Message definition file, included multiple times, hence no include guard.
+
+#include "base/strings/string16.h"
+#include "ipc/ipc_message_macros.h"
+#include "ipc/ipc_param_traits.h"
+#include "url/gurl.h"
+
+#define IPC_MESSAGE_START NavControllerMsgStart
+
+IPC_MESSAGE_CONTROL3(NavControllerHostMsg_RegisterController,
Tom Sepez 2013/09/13 21:48:34 nit: Generally, I'd split these into browser -> re
+ int32 /* registry_id */,
+ string16 /* scope */,
Tom Sepez 2013/09/13 21:48:34 What is scope? Can you give an example? In parti
+ GURL /* script_url */)
+
+IPC_MESSAGE_CONTROL1(NavControllerMsg_ControllerReady, int32 /* registry_id */)
Tom Sepez 2013/09/13 21:48:34 nit: maybe a comment about "Response to ..." in al
+
+IPC_MESSAGE_CONTROL2(NavControllerHostMsg_UnregisterController,
+ int32 /* registry_id */,
+ string16 /* scope */)
+
+IPC_MESSAGE_CONTROL2(NavControllerMsg_ControllerUnregistered,
+ int32 /* registry_id */,
+ string16 /* scope */)

Powered by Google App Engine
This is Rietveld 408576698