content/common/nav_controller_messages.h - Issue 23615009: Stub out initial NavigationController browser implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/nav_controller_messages.h

Issue 23615009: Stub out initial NavigationController browser implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add comments, s/peer/registry/ now that blink side is settled Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Message definition file, included multiple times, hence no include guard.

	6

	7 #include "base/strings/string16.h"

	8 #include "ipc/ipc_message_macros.h"

	9 #include "ipc/ipc_param_traits.h"

	10 #include "url/gurl.h"

	11

	12 #define IPC_MESSAGE_START NavControllerMsgStart

	13

	14 IPC_MESSAGE_CONTROL3(NavControllerHostMsg_RegisterController,
	Tom Sepez 2013/09/13 21:48:34 nit: Generally, I'd split these into browser -> re nit: Generally, I'd split these into browser -> renderer and renderer -> browser sections, with a comment indicating which way the messages are going for each section (even though the HostMsg_ indicates this).
	15 int32 /* registry_id */,

	16 string16 /* scope */,
	Tom Sepez 2013/09/13 21:48:34 What is scope? Can you give an example? In parti What is scope? Can you give an example? In particluar, if its some structured list we'd prefer that it not be tunnelled through IPC using strings. If not, then ... nevermind.
	17 GURL /* script_url */)

	18

	19 IPC_MESSAGE_CONTROL1(NavControllerMsg_ControllerReady, int32 /* registry_id */)
	Tom Sepez 2013/09/13 21:48:34 nit: maybe a comment about "Response to ..." in al nit: maybe a comment about "Response to ..." in all places.
	20

	21 IPC_MESSAGE_CONTROL2(NavControllerHostMsg_UnregisterController,

	22 int32 /* registry_id */,

	23 string16 /* scope */)

	24

	25 IPC_MESSAGE_CONTROL2(NavControllerMsg_ControllerUnregistered,

	26 int32 /* registry_id */,

	27 string16 /* scope */)

OLD	NEW

« content/browser/nav_controller/nav_controller_dispatcher_host.cc ('K') | « content/common/content_message_generator.h ('k') | content/content_browser.gypi » ('j') | no next file with comments »