Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2361473004: Revert of fix for conic fuzz (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of fix for conic fuzz (patchset #3 id:40001 of https://codereview.chromium.org/2350263003/ ) Reason for revert: See if this fixes the layout tests. Original issue's description: > fix for conic fuzz > > A fuzzer generates a conic that hangs when drawn. > The quads that approximate the conics move up and down > in y, confusing the renderer. > > This fix ensures that the split conic maintains the > same y direction as the original conic. > > R=reed@google.com > BUG=647922 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350263003 > > Committed: https://skia.googlesource.com/skia/+/ac78863acdef4b428aaf66985b80c76d1be0fdea TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=647922 Committed: https://skia.googlesource.com/skia/+/08b345588414b861af8a55950e7dc21a1bd85a28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46 lines) Patch
M src/core/SkGeometry.cpp View 2 chunks +0 lines, -32 lines 0 comments Download
M tests/PathTest.cpp View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
caryclark
Created Revert of fix for conic fuzz
4 years, 3 months ago (2016-09-22 14:42:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361473004/1
4 years, 3 months ago (2016-09-22 14:42:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/08b345588414b861af8a55950e7dc21a1bd85a28
4 years, 3 months ago (2016-09-22 14:42:42 UTC) #5
caryclark
4 years, 3 months ago (2016-09-22 17:24:49 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2359253002/ by caryclark@google.com.

The reason for reverting is: Landed suppression in Chrome's
LayoutTests/TestExpectations.

Powered by Google App Engine
This is Rietveld 408576698