Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2361433002: Async is no longer optional (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -477 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 6 chunks +0 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 6 chunks +7 lines, -69 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 7 chunks +11 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 5 chunks +4 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +0 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 2 chunks +0 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/analysis_context_factory.dart View 3 chunks +90 lines, -105 lines 0 comments Download
M pkg/analyzer/test/generated/package_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 4 chunks +0 lines, -120 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 6 chunks +9 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 4 chunks +1 line, -64 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-09-21 14:51:29 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-21 14:56:03 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-09-21 15:29:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d947a7ba8922aa99b811fed603fd2fddbc871781 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698