Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: pkg/analyzer/test/src/task/dart_test.dart

Issue 2361433002: Async is no longer optional (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/context/builder_test.dart ('k') | pkg/analyzer/test/src/task/options_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/dart_test.dart
diff --git a/pkg/analyzer/test/src/task/dart_test.dart b/pkg/analyzer/test/src/task/dart_test.dart
index f9ebf8c5442bb539f425ece56112993b6d3048fd..8b32c54ce6fbaaa743ef5c69c97adfeacadb1e82 100644
--- a/pkg/analyzer/test/src/task/dart_test.dart
+++ b/pkg/analyzer/test/src/task/dart_test.dart
@@ -15,7 +15,7 @@ import 'package:analyzer/src/dart/element/element.dart';
import 'package:analyzer/src/error/codes.dart';
import 'package:analyzer/src/generated/constant.dart';
import 'package:analyzer/src/generated/engine.dart'
- show AnalysisOptions, AnalysisOptionsImpl, CacheState;
+ show AnalysisOptionsImpl, CacheState;
import 'package:analyzer/src/generated/resolver.dart';
import 'package:analyzer/src/generated/sdk.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -45,7 +45,6 @@ main() {
defineReflectiveTests(BuildPublicNamespaceTaskTest);
defineReflectiveTests(BuildSourceExportClosureTaskTest);
defineReflectiveTests(BuildTypeProviderTaskTest);
- defineReflectiveTests(BuildTypeProviderTaskTest_noAsync);
defineReflectiveTests(ComputeConstantDependenciesTaskTest);
defineReflectiveTests(ComputeConstantValueTaskTest);
defineReflectiveTests(ComputeInferableStaticVariableDependenciesTaskTest);
@@ -1128,29 +1127,6 @@ class BuildTypeProviderTaskTest extends _AbstractDartTaskTest {
}
@reflectiveTest
-class BuildTypeProviderTaskTest_noAsync extends _AbstractDartTaskTest {
- DartSdk createDartSdk() => new MockSdk(dartAsync: false);
-
- void prepareAnalysisContext([AnalysisOptions options]) {
- AnalysisOptionsImpl newOptions = new AnalysisOptionsImpl();
- newOptions.enableAsync = false;
- super.prepareAnalysisContext(newOptions);
- }
-
- test_perform_noAsync() {
- expect(context, isNotNull);
- computeResult(AnalysisContextTarget.request, TYPE_PROVIDER,
- matcher: isBuildTypeProviderTask);
- // validate
- TypeProvider typeProvider = outputs[TYPE_PROVIDER];
- expect(typeProvider, isNotNull);
- expect(typeProvider.boolType, isNotNull);
- expect(typeProvider.intType, isNotNull);
- expect(typeProvider.futureType, isNotNull);
- }
-}
-
-@reflectiveTest
class ComputeConstantDependenciesTaskTest extends _AbstractDartTaskTest {
Annotation findClassAnnotation(CompilationUnit unit, String className) {
for (CompilationUnitMember member in unit.declarations) {
@@ -3196,45 +3172,6 @@ part 'test.dart';
expect(outputs[UNITS], hasLength(1));
}
- test_perform_enableAsync_false() {
- AnalysisOptionsImpl options = new AnalysisOptionsImpl();
- options.enableAsync = false;
- prepareAnalysisContext(options);
- _performParseTask(r'''
-import 'dart:async';
-class B {void foo() async {}}''');
- expect(outputs, hasLength(11));
- expect(outputs[EXPLICITLY_IMPORTED_LIBRARIES], hasLength(1));
- expect(outputs[EXPORTED_LIBRARIES], hasLength(0));
- _assertHasCore(outputs[IMPORTED_LIBRARIES], 2);
- expect(outputs[INCLUDED_PARTS], hasLength(0));
- expect(outputs[LIBRARY_SPECIFIC_UNITS], hasLength(1));
- expect(outputs[PARSE_ERRORS], hasLength(1));
- expect(outputs[PARSED_UNIT], isNotNull);
- expect(outputs[REFERENCED_NAMES], isNotNull);
- expect(outputs[REFERENCED_SOURCES], hasLength(3));
- expect(outputs[SOURCE_KIND], SourceKind.LIBRARY);
- expect(outputs[UNITS], hasLength(1));
- }
-
- test_perform_enableAsync_true() {
- _performParseTask(r'''
-import 'dart:async';
-class B {void foo() async {}}''');
- expect(outputs, hasLength(11));
- expect(outputs[EXPLICITLY_IMPORTED_LIBRARIES], hasLength(1));
- expect(outputs[EXPORTED_LIBRARIES], hasLength(0));
- _assertHasCore(outputs[IMPORTED_LIBRARIES], 2);
- expect(outputs[INCLUDED_PARTS], hasLength(0));
- expect(outputs[LIBRARY_SPECIFIC_UNITS], hasLength(1));
- expect(outputs[PARSE_ERRORS], hasLength(0));
- expect(outputs[PARSED_UNIT], isNotNull);
- expect(outputs[REFERENCED_NAMES], isNotNull);
- expect(outputs[REFERENCED_SOURCES], hasLength(3));
- expect(outputs[SOURCE_KIND], SourceKind.LIBRARY);
- expect(outputs[UNITS], hasLength(1));
- }
-
test_perform_flushTokenStream() {
_performParseTask(r'''
class Test {}
« no previous file with comments | « pkg/analyzer/test/src/context/builder_test.dart ('k') | pkg/analyzer/test/src/task/options_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698