Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: src/runtime.h

Issue 236133005: Handlify Runtime::InitializeIntrinsicFunctionNames. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/runtime.cc » ('j') | src/runtime.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.h
diff --git a/src/runtime.h b/src/runtime.h
index 3a5c4546a7f35ac099924558bf8f97eb011487b2..5ee345c645480bd7247b44670bc65c19b16706ef 100644
--- a/src/runtime.h
+++ b/src/runtime.h
@@ -801,8 +801,9 @@ class Runtime : public AllStatic {
// Returns failure if an allocation fails. In this case, it must be
Michael Starzinger 2014/04/14 11:10:50 nit: Comment is outdated, I think we can drop the
// retried with a new, empty StringDictionary, not with the same one.
// Alternatively, heap initialization can be completely restarted.
- MUST_USE_RESULT static MaybeObject* InitializeIntrinsicFunctionNames(
- Heap* heap, Object* dictionary);
+ static Handle<NameDictionary> InitializeIntrinsicFunctionNames(
Michael Starzinger 2014/04/14 11:10:50 Since we have the invariant that the dictionary do
+ Isolate* isolate,
+ Handle<NameDictionary> dict);
// Get the intrinsic function with the given name, which must be internalized.
static const Function* FunctionForName(Handle<String> name);
« no previous file with comments | « src/objects.cc ('k') | src/runtime.cc » ('j') | src/runtime.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698