Handlify Runtime::InitializeIntrinsicFunctionNames.

src/runtime.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 780 matching lines @@
     // a variable number of arguments.
     int nargs;
     // Size of result.  Most functions return a single pointer, size 1.
     int result_size;
   };
 
   static const int kNotFound = -1;
 
   // Add internalized strings for all the intrinsic function names to a
   // StringDictionary.
   // Returns failure if an allocation fails.  In this case, it must be

[Michael Starzinger, 2014/04/14 11:10:50]

nit: Comment is outdated, I think we can drop the last two sentences.

   // retried with a new, empty StringDictionary, not with the same one.
   // Alternatively, heap initialization can be completely restarted.
-  MUST_USE_RESULT static MaybeObject* InitializeIntrinsicFunctionNames(
-      Heap* heap, Object* dictionary);
+  static Handle<NameDictionary> InitializeIntrinsicFunctionNames(

[Michael Starzinger, 2014/04/14 11:10:50]

Since we have the invariant that the dictionary does not change, can we change
the signature to return "void" instead?

+      Isolate* isolate,
+      Handle<NameDictionary> dict);
 
   // Get the intrinsic function with the given name, which must be internalized.
   static const Function* FunctionForName(Handle<String> name);
 
   // Get the intrinsic function with the given FunctionId.
   static const Function* FunctionForId(FunctionId id);
 
   // General-purpose helper functions for runtime system.
   static int StringMatch(Isolate* isolate,
                          Handle<String> sub,
@@ skipping 97 matching lines @@
 class AllocateDoubleAlignFlag:  public BitField<bool,            0, 1> {};
 class AllocateTargetSpace:      public BitField<AllocationSpace, 1, 3> {};
 
 class DeclareGlobalsEvalFlag:   public BitField<bool,       0, 1> {};
 class DeclareGlobalsNativeFlag: public BitField<bool,       1, 1> {};
 class DeclareGlobalsStrictMode: public BitField<StrictMode, 2, 1> {};
 
 } }  // namespace v8::internal
 
 #endif  // V8_RUNTIME_H_