Handlify Runtime::InitializeIntrinsicFunctionNames.

Handlify Runtime::InitializeIntrinsicFunctionNames.

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20718

[Michael Starzinger, 2014-04-14 11:10:50]

LGTM with comments.

https://codereview.chromium.org/236133005/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/236133005/diff/1/src/runtime.cc#newcode15097
src/runtime.cc:15097: HandleScope scope(isolate);
Do we need this handle scope at all? If yes, then we should at least move it out
of the loop. If no, lets drop it completely.

https://codereview.chromium.org/236133005/diff/1/src/runtime.h
File src/runtime.h (right):

https://codereview.chromium.org/236133005/diff/1/src/runtime.h#newcode801
src/runtime.h:801: // Returns failure if an allocation fails.  In this case, it
must be
nit: Comment is outdated, I think we can drop the last two sentences.

https://codereview.chromium.org/236133005/diff/1/src/runtime.h#newcode804
src/runtime.h:804: static Handle<NameDictionary>
InitializeIntrinsicFunctionNames(
Since we have the invariant that the dictionary does not change, can we change
the signature to return "void" instead?

[Yang, 2014-04-14 11:32:20]

Committed patchset #2 manually as r20718 (presubmit successful).