Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: Source/bindings/v8/CallbackPromiseAdapter.h

Issue 236133002: Pass script state to Web API object->script wrappable converter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Also pass script state to "from" for error types. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/push_messaging/PushError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/CallbackPromiseAdapter.h
diff --git a/Source/bindings/v8/CallbackPromiseAdapter.h b/Source/bindings/v8/CallbackPromiseAdapter.h
index 612dfb9863f97e85214679a346da086dd4c76de3..af2216728f4ce3a33847aad980f6bb4e410bde02 100644
--- a/Source/bindings/v8/CallbackPromiseAdapter.h
+++ b/Source/bindings/v8/CallbackPromiseAdapter.h
@@ -47,7 +47,8 @@ namespace WebCore {
//
// class MyClass ... {
// typedef blink::WebMyClass WebType;
-// static PassRefPtr<MyClass> from(blink::WebMyClass* webInstance) {
+// static PassRefPtr<MyClass> from(NewScriptState*,
+// blink::WebMyClass* webInstance) {
// // convert/create as appropriate, but often it's just:
// return MyClass::create(adoptPtr(webInstance));
// }
@@ -73,12 +74,12 @@ public:
virtual void onSuccess(typename S::WebType* result) OVERRIDE
{
NewScriptState::Scope scope(m_scriptState.get());
- m_resolver->resolve(S::from(result));
+ m_resolver->resolve(S::from(m_scriptState.get(), result));
}
virtual void onError(typename T::WebType* error) OVERRIDE
{
NewScriptState::Scope scope(m_scriptState.get());
- m_resolver->reject(T::from(error));
+ m_resolver->reject(T::from(m_scriptState.get(), error));
}
private:
RefPtr<ScriptPromiseResolver> m_resolver;
« no previous file with comments | « no previous file | Source/modules/push_messaging/PushError.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698