Source/modules/push_messaging/PushError.h - Issue 236133002: Pass script state to Web API object->script wrappable converter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushError.h

Issue 236133002: Pass script state to Web API object->script wrappable converter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Also pass script state to "from" for error types. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/push_messaging/PushError.h

diff --git a/Source/modules/push_messaging/PushError.h b/Source/modules/push_messaging/PushError.h

index 667eb923afc706f613aa3ab8539df8994f928c3e..7840cc08696ada8e0e7697d0031b5ca6b092db58 100644

--- a/Source/modules/push_messaging/PushError.h

+++ b/Source/modules/push_messaging/PushError.h

@@ -12,12 +12,14 @@

namespace WebCore {

+class NewScriptState;

class PushError {

WTF_MAKE_NONCOPYABLE(PushError);

public:

// For CallbackPromiseAdapter.

typedef blink::WebPushError WebType;

- static PassRefPtrWillBeRawPtr<DOMError> from(WebType* webErrorRaw)

+ static PassRefPtrWillBeRawPtr<DOMError> from(NewScriptState*, WebType* webErrorRaw)

{

OwnPtr<WebType> webError = adoptPtr(webErrorRaw);

RefPtrWillBeRawPtr<DOMError> error = DOMError::create(errorString(webError->errorType), webError->message);