Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl

Issue 2361303003: Sync IntersectionObserver IDL with the spec (Closed)
Patch Set: Array->Sequence Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl
diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl b/third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl
index f333646a8b123c95ac977fca1077513d04219843..ef0de4ab51136cad3a086dea91321d5e64ccb8f6 100644
--- a/third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl
+++ b/third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl
@@ -2,12 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(szager): link to final spec
+// https://wicg.github.io/IntersectionObserver/#intersection-observer-init
-[
- RuntimeEnabled=IntersectionObserver
szager1 2016/10/01 00:03:30 Can you remove RuntimeEnabled=IntersectionObserver
foolip 2016/10/01 15:23:20 I actually removed it since [RuntimeEnabled] doesn
foolip 2016/10/01 15:33:18 https://codereview.chromium.org/2390483002 I'll l
-] dictionary IntersectionObserverInit {
- Element? root;
- DOMString rootMargin;
- (double or double[]) threshold = 0;
+dictionary IntersectionObserverInit {
+ Element? root = null;
+ DOMString rootMargin = "0px";
+ (double or sequence<double>) threshold = 0;
};

Powered by Google App Engine
This is Rietveld 408576698