DevTools: Move "enter" logic from ConsoleView to ConsolePrompt

DevTools: Move "enter" logic from ConsoleView to ConsolePrompt
Also fixes a bug where enter was never captured by the SuggestBox.

BUG=650155
Committed: https://crrev.com/9926833faef089c9f45c303a0e0664083b0f64ad
Cr-Commit-Position: refs/heads/master@{#421088}

[einbinder, 2016-09-22 22:38:13]

einbinder@chromium.org changed reviewers:
+ luoe@chromium.org, lushnikov@chromium.org

[einbinder, 2016-09-22 22:38:14]

ptal

https://codereview.chromium.org/2361273002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/console/console-smart-enter-expected.txt
(right):

https://codereview.chromium.org/2361273002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/console/console-smart-enter-expected.txt:77:
<empty>
This test was actually not testing what it should have been.

https://codereview.chromium.org/2361273002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
(left):

https://codereview.chromium.org/2361273002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js:84: /**
All these helper methods get to go away!

[lushnikov, 2016-09-23 00:50:06]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-09-23 00:50:06]

lgtm

[commit-bot: I haz the power, 2016-09-23 00:50:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 00:54:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 00:54:05]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[luoe, 2016-09-23 00:56:05]

lgtm as well

[einbinder, 2016-09-23 02:04:57]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-09-23 02:04:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org, luoe@chromium.org
Link to the patchset: https://codereview.chromium.org/2361273002/#ps20001
(title: "merge")

[commit-bot: I haz the power, 2016-09-23 02:05:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 02:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 02:58:34]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2016-09-26 18:09:42]

Description was changed from

==========
DevTools: Move "enter" logic from ConsoleView to ConsolePrompt

BUG=none
==========

to

==========
DevTools: Move "enter" logic from ConsoleView to ConsolePrompt
Also fixes a bug where enter was never captured by the SuggestBox.

BUG=650155
==========

[einbinder, 2016-09-26 18:10:29]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-09-26 18:10:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org, luoe@chromium.org
Link to the patchset: https://codereview.chromium.org/2361273002/#ps40001
(title: "Fix browser tests")

[commit-bot: I haz the power, 2016-09-26 18:11:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 19:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 19:33:44]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lushnikov, 2016-09-27 01:26:59]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-09-27 01:27:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 03:04:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 03:07:25]

Description was changed from

==========
DevTools: Move "enter" logic from ConsoleView to ConsolePrompt
Also fixes a bug where enter was never captured by the SuggestBox.

BUG=650155
==========

to

==========
DevTools: Move "enter" logic from ConsoleView to ConsolePrompt
Also fixes a bug where enter was never captured by the SuggestBox.

BUG=650155

Committed: https://crrev.com/9926833faef089c9f45c303a0e0664083b0f64ad
Cr-Commit-Position: refs/heads/master@{#421088}
==========

[commit-bot: I haz the power, 2016-09-27 03:07:26]

Patchset 3 (id:??) landed as
https://crrev.com/9926833faef089c9f45c303a0e0664083b0f64ad
Cr-Commit-Position: refs/heads/master@{#421088}