third_party/WebKit/Source/devtools/front_end/Tests.js - Issue 2361273002: DevTools: Move "enter" logic from ConsoleView to ConsolePrompt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/Tests.js

Issue 2361273002: DevTools: Move "enter" logic from ConsoleView to ConsolePrompt (Closed)

Patch Set: Fix browser tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/Tests.js

diff --git a/third_party/WebKit/Source/devtools/front_end/Tests.js b/third_party/WebKit/Source/devtools/front_end/Tests.js

index c92b7e386119098dd87c10c2525e617c00975e4a..0089a703d0c7c5f4630543b97f59ef58e2a50b63 100644

--- a/third_party/WebKit/Source/devtools/front_end/Tests.js

+++ b/third_party/WebKit/Source/devtools/front_end/Tests.js

@@ -1109,8 +1109,7 @@ TestSuite.prototype.evaluateInConsole_ = function(code, callback)

{

WebInspector.context.removeFlavorChangeListener(WebInspector.ExecutionContext, showConsoleAndEvaluate, this);

var consoleView = WebInspector.ConsoleView.instance();

- consoleView._prompt.setText(code);

- consoleView._prompt.element.dispatchEvent(TestSuite.createKeyEvent("Enter"));

+ consoleView._prompt._appendCommand(code);

this.addSniffer(WebInspector.ConsoleView.prototype, "_consoleMessageAddedForTest",

function(viewMessage) {