Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2361263002: libvpx: enable high bit depth for vp9 (Closed)

Created:
4 years, 3 months ago by Johann
Modified:
3 years, 11 months ago
Reviewers:
jzern, Nico
CC:
chromium-reviews, wwcv, fgalligan1, Tom Finegan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libvpx: enable high bit depth for vp9 Allow the library to process 8 bit (plus high bitdepth internal), 10 bit, and 12 bit files. Only for x86 targets. Performance for 8 bit (regular internal) is within 1-2% for these targets. BUG=445071 R=jzern Committed: https://crrev.com/8d5b2859f6245d3e84a53e985de4b8a9f64afc9d Cr-Commit-Position: refs/heads/master@{#420523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7950 lines, -242 lines) Patch
M third_party/libvpx/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/libvpx_srcs.gni View 8 chunks +26 lines, -4 lines 0 comments Download
M third_party/libvpx/source/config/linux/ia32/vp9_rtcd.h View 6 chunks +56 lines, -28 lines 0 comments Download
M third_party/libvpx/source/config/linux/ia32/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/linux/ia32/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/linux/ia32/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/linux/ia32/vpx_dsp_rtcd.h View 5 chunks +1434 lines, -4 lines 0 comments Download
M third_party/libvpx/source/config/linux/x64/vp9_rtcd.h View 5 chunks +54 lines, -29 lines 0 comments Download
M third_party/libvpx/source/config/linux/x64/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/linux/x64/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/linux/x64/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/linux/x64/vpx_dsp_rtcd.h View 5 chunks +1091 lines, -12 lines 0 comments Download
M third_party/libvpx/source/config/mac/ia32/vp9_rtcd.h View 6 chunks +56 lines, -28 lines 0 comments Download
M third_party/libvpx/source/config/mac/ia32/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/mac/ia32/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/mac/ia32/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/mac/ia32/vpx_dsp_rtcd.h View 5 chunks +1434 lines, -4 lines 0 comments Download
M third_party/libvpx/source/config/mac/x64/vp9_rtcd.h View 5 chunks +54 lines, -29 lines 0 comments Download
M third_party/libvpx/source/config/mac/x64/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/mac/x64/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/mac/x64/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/mac/x64/vpx_dsp_rtcd.h View 5 chunks +1091 lines, -12 lines 0 comments Download
M third_party/libvpx/source/config/win/ia32/vp9_rtcd.h View 6 chunks +56 lines, -28 lines 0 comments Download
M third_party/libvpx/source/config/win/ia32/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/win/ia32/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/win/ia32/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/win/ia32/vpx_dsp_rtcd.h View 5 chunks +1434 lines, -4 lines 0 comments Download
M third_party/libvpx/source/config/win/x64/vp9_rtcd.h View 5 chunks +54 lines, -29 lines 0 comments Download
M third_party/libvpx/source/config/win/x64/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/win/x64/vpx_config.asm View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/win/x64/vpx_config.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libvpx/source/config/win/x64/vpx_dsp_rtcd.h View 5 chunks +1091 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Johann
http://imgur.com/7drHiqr
4 years, 3 months ago (2016-09-22 22:18:49 UTC) #3
jzern
On 2016/09/22 22:18:49, Johann wrote: > http://imgur.com/7drHiqr lgtm. this will increase binary size so may ...
4 years, 3 months ago (2016-09-22 23:12:13 UTC) #5
Johann
win_clang *seems* unrelated but it's tricky: FAILED: angle_unittests.exe angle_unittests.exe.pdb E:/b/depot_tools/python276_bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe ...
4 years, 3 months ago (2016-09-22 23:14:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361263002/1
4 years, 3 months ago (2016-09-22 23:15:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 01:07:10 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8d5b2859f6245d3e84a53e985de4b8a9f64afc9d Cr-Commit-Position: refs/heads/master@{#420523}
4 years, 3 months ago (2016-09-23 01:10:43 UTC) #11
Nico
This apparently increased binary size of chrome by half a meg (https://bugs.chromium.org/p/chromium/issues/detail?id=457078#c78). Was that expected?
3 years, 11 months ago (2017-01-13 19:14:03 UTC) #13
Johann
On 2017/01/13 19:14:03, Nico wrote: > This apparently increased binary size of chrome by half ...
3 years, 11 months ago (2017-01-13 19:15:41 UTC) #14
Nico
Thanks for the fast reply! On Fri, Jan 13, 2017 at 2:15 PM, <johannkoenig@google.com> wrote: ...
3 years, 11 months ago (2017-01-13 19:20:55 UTC) #15
Johann
3 years, 11 months ago (2017-01-13 19:22:07 UTC) #16
Message was sent while issue was closed.
On 2017/01/13 19:20:55, Nico wrote:
> Thanks for the fast reply!

No problem. Sorry it's not better news ...

Powered by Google App Engine
This is Rietveld 408576698