Chromium Code Reviews Chromium Code Reviews
Issue
236123002:
Allow pass through buffer sizes on OSX. (Closed)
DescriptionAllow pass through buffer sizes on OSX.
Previously we've prevented streams from being created with arbitrary
buffer sizes since one size is shared across all input and output
streams in the process.
As of a few months ago the input and output paths now both have FIFO
queues to overcome circumstances where the buffer size requested from
OSX doesn't match what it actually asks for.
With the FIFOs in place, it's no longer necessary for us to ensure a
single buffer size is used across the process. What is instead done is
to only raise the buffer size if an input or output stream is the sole
active output stream.
As measured by coreaudiod on my MacBook Pro this results in a savings of
1 - 5% of CPU! Going from 3->5% total to 0.3%.
BUG=362261
TEST=Extensive manual testing.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264741
Patch Set 1 : Fix comments. #
Total comments: 11
Patch Set 2 : Comments. Rebase. #
Total comments: 2
Patch Set 3 : Comments. #
Messages
Total messages: 10 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
