Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2361203004: Issue 27358. Reset AnalysisContext 'sourceFactory' and 'typeSystem' on analysis options change. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 27358. Reset AnalysisContext 'sourceFactory' and 'typeSystem' on analysis options change. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/27358 Committed: https://github.com/dart-lang/sdk/commit/09b0bba932c3403b7fa414eec69048af69f85621

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1 line) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +2 lines, -1 line 1 comment Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +52 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-23 04:02:36 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2361203004/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/2361203004/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode888 pkg/analysis_server/lib/src/context_manager.dart:888: // TODO(brianwilkerson) This doesn't correctly update the source ...
4 years, 3 months ago (2016-09-23 13:56:54 UTC) #2
scheglov
4 years, 3 months ago (2016-09-23 16:44:53 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
09b0bba932c3403b7fa414eec69048af69f85621 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698