Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1753)

Unified Diff: pkg/analysis_server/lib/src/context_manager.dart

Issue 2361203004: Issue 27358. Reset AnalysisContext 'sourceFactory' and 'typeSystem' on analysis options change. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/context_manager_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/context_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart
index 7d567a9d8fd15f1910e086e3a733f3826e0949f6..8e9787a3b0ef1972d51e9a7201b68887d39c7c68 100644
--- a/pkg/analysis_server/lib/src/context_manager.dart
+++ b/pkg/analysis_server/lib/src/context_manager.dart
@@ -891,7 +891,8 @@ class ContextManagerImpl implements ContextManager {
Map<String, Object> options = readOptions(info.folder);
processOptionsForContext(info, options,
optionsRemoved: changeType == ChangeType.REMOVE);
- analysisContext.invalidateCachedResults();
+ analysisContext.sourceFactory = _createSourceFactory(
+ analysisContext, analysisContext.analysisOptions, info.folder);
callbacks.applyChangesToContext(info.folder, new ChangeSet());
}
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/context_manager_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698