Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2361203002: Remove calls to MessageLoop::Run/RunUntilIdle. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 2 months ago
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, chromium-reviews, davemoore+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, oshima+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to MessageLoop::Run/RunUntilIdle. These methods are deprecated. RunLoop should be used instead. BUG=616447 TBR=eugenebut@chromium.org Committed: https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3 Cr-Commit-Position: refs/heads/master@{#420950}

Patch Set 1 #

Patch Set 2 : add missing calls #

Patch Set 3 : remove new call #

Patch Set 4 : add new call #

Total comments: 2

Patch Set 5 : CR jochen #6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -46 lines) Patch
M chrome/browser/chromeos/login/oobe_localization_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc/native_desktop_media_list_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils.h View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 1 2 3 4 3 chunks +10 lines, -33 lines 0 comments Download
M components/previews/core/previews_io_data_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M components/previews/core/previews_ui_service_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/net/request_tracker_impl_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/public/test/web_test_with_web_state.mm View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/audio/android/audio_android_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
fdoray
jochen@chromium.org: Please review changes in chrome/utility xiyuan@chromium.org: Please review changes in chrome/browser/chromeos ryansturm@chromium.org: Please review ...
4 years, 2 months ago (2016-09-26 14:43:54 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 2 months ago (2016-09-26 14:52:40 UTC) #5
jochen (gone - plz use gerrit)
utility lgtm with comment https://codereview.chromium.org/2361203002/diff/60001/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc File chrome/utility/importer/firefox_importer_unittest_utils_mac.cc (right): https://codereview.chromium.org/2361203002/diff/60001/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc#newcode194 chrome/utility/importer/firefox_importer_unittest_utils_mac.cc:194: return true; just make the ...
4 years, 2 months ago (2016-09-26 15:11:32 UTC) #6
RyanSturm
Previews lgtm
4 years, 2 months ago (2016-09-26 15:22:46 UTC) #7
xiyuan
c/b/chromeos lgtm
4 years, 2 months ago (2016-09-26 16:11:37 UTC) #8
fdoray
TBR eugenebut@chromium.org because there longer we wait to land this, the more chances there are ...
4 years, 2 months ago (2016-09-26 17:22:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361203002/60001
4 years, 2 months ago (2016-09-26 17:22:44 UTC) #12
fdoray
TBR eugenebut@chromium.org because the longer we wait to land this, the more chances there are ...
4 years, 2 months ago (2016-09-26 17:22:46 UTC) #13
fdoray
https://codereview.chromium.org/2361203002/diff/60001/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc File chrome/utility/importer/firefox_importer_unittest_utils_mac.cc (right): https://codereview.chromium.org/2361203002/diff/60001/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc#newcode194 chrome/utility/importer/firefox_importer_unittest_utils_mac.cc:194: return true; On 2016/09/26 15:11:32, jochen (slow) wrote: > ...
4 years, 2 months ago (2016-09-26 17:26:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361203002/80001
4 years, 2 months ago (2016-09-26 17:26:48 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-09-26 18:53:26 UTC) #20
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/cdc92d477d3700ef5a8ad34d2098975f832f9ef3 Cr-Commit-Position: refs/heads/master@{#420950}
4 years, 2 months ago (2016-09-26 18:55:26 UTC) #22
Eugene But (OOO till 7-30)
4 years, 2 months ago (2016-09-26 22:01:58 UTC) #23
Message was sent while issue was closed.
ios/web lgtm

Powered by Google App Engine
This is Rietveld 408576698