Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Side by Side Diff: components/previews/core/previews_ui_service_unittest.cc

Issue 2361203002: Remove calls to MessageLoop::Run/RunUntilIdle. (Closed)
Patch Set: CR jochen #6 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/previews/core/previews_ui_service.h" 5 #include "components/previews/core/previews_ui_service.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/message_loop/message_loop.h" 11 #include "base/message_loop/message_loop.h"
12 #include "base/run_loop.h"
12 #include "base/single_thread_task_runner.h" 13 #include "base/single_thread_task_runner.h"
13 #include "components/previews/core/previews_io_data.h" 14 #include "components/previews/core/previews_io_data.h"
14 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
15 16
16 namespace previews { 17 namespace previews {
17 18
18 namespace { 19 namespace {
19 20
20 class TestPreviewsUIService : public PreviewsUIService { 21 class TestPreviewsUIService : public PreviewsUIService {
21 public: 22 public:
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 std::unique_ptr<TestPreviewsUIService> ui_service_; 71 std::unique_ptr<TestPreviewsUIService> ui_service_;
71 }; 72 };
72 73
73 } // namespace 74 } // namespace
74 75
75 TEST_F(PreviewsUIServiceTest, TestInitialization) { 76 TEST_F(PreviewsUIServiceTest, TestInitialization) {
76 set_io_data(base::WrapUnique( 77 set_io_data(base::WrapUnique(
77 new PreviewsIOData(loop_.task_runner(), loop_.task_runner()))); 78 new PreviewsIOData(loop_.task_runner(), loop_.task_runner())));
78 set_ui_service(base::WrapUnique( 79 set_ui_service(base::WrapUnique(
79 new TestPreviewsUIService(io_data(), loop_.task_runner(), nullptr))); 80 new TestPreviewsUIService(io_data(), loop_.task_runner(), nullptr)));
80 loop_.RunUntilIdle(); 81 base::RunLoop().RunUntilIdle();
81 // After the outstanding posted tasks have run, SetIOData should have been 82 // After the outstanding posted tasks have run, SetIOData should have been
82 // called for |ui_service_|. 83 // called for |ui_service_|.
83 EXPECT_TRUE(ui_service()->io_data_set()); 84 EXPECT_TRUE(ui_service()->io_data_set());
84 } 85 }
85 86
86 } // namespace previews 87 } // namespace previews
OLDNEW
« no previous file with comments | « components/previews/core/previews_io_data_unittest.cc ('k') | ios/web/net/request_tracker_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698