Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2361183002: Respect setLibraryDebuggable (Closed)

Created:
4 years, 2 months ago by Cutch
Modified:
4 years, 2 months ago
Reviewers:
rmacnak, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Respect setLibraryDebuggable - [x] Mark all libraries debuggable by default - [x] Mark all dart:_* libraries as not debuggable by default - [x] Respect setLibraryDebuggable - [x] Add set library debuggable test case - [x] Do not allow dart:_* libraries to be marked debuggable Fixes https://github.com/dart-lang/sdk/issues/27370 BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/48c6f19600bf86446b406355c9d45b372684ac5c

Patch Set 1 #

Patch Set 2 : Respect setLibraryDebuggable #

Patch Set 3 : Respect setLibraryDebuggable #

Patch Set 4 : Respect setLibraryDebuggable #

Patch Set 5 : Respect setLibraryDebuggable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -12 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 1 3 chunks +42 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/set_library_debuggable_rpc_test.dart View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/set_library_debuggable_test.dart View 1 2 3 4 1 chunk +65 lines, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 3 chunks +1 line, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/service.cc View 1 2 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Cutch
4 years, 2 months ago (2016-09-22 19:48:18 UTC) #3
rmacnak
lgtm
4 years, 2 months ago (2016-09-22 21:31:42 UTC) #4
Cutch
Committed patchset #5 (id:80001) manually as 48c6f19600bf86446b406355c9d45b372684ac5c (presubmit successful).
4 years, 2 months ago (2016-09-23 17:45:58 UTC) #9
hausner
DBC: The default in the older debugger was to mark all dart libraries as non-debuggable ...
4 years, 2 months ago (2016-09-23 18:02:16 UTC) #11
Cutch
4 years, 2 months ago (2016-09-23 18:04:38 UTC) #12
Message was sent while issue was closed. 
On 2016/09/23 18:02:16, hausner wrote:
> DBC: The default in the older debugger was to mark all dart libraries as
> non-debuggable by default. The client can then change them to debuggable if it
> wants to.
> 
> This default was chosen because users did not want to step into the
intricacies
> of the library code when they single step simple code like 'a + 1'.
> 
> The defaults you chose with this CL burdens the user to mark dart libraries as
> non-debuggable each time they load a program.

For well over a year all libraries were debuggable and no one complained.

Powered by Google App Engine
This is Rietveld 408576698