Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: runtime/vm/debugger.cc

Issue 2361183002: Respect setLibraryDebuggable (Closed)
Patch Set: Respect setLibraryDebuggable Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/set_library_debuggable_test.dart ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index 54694feafbf7cd28b1e33e5f8286f1f33c7e93fd..51c6721d9edeccb9de890220ece86563f642d5dc 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -2613,9 +2613,6 @@ bool Debugger::IsDebuggable(const Function& func) {
if (!func.is_debuggable()) {
return false;
}
- if (ServiceIsolate::IsRunning()) {
- return true;
- }
const Class& cls = Class::Handle(func.Owner());
const Library& lib = Library::Handle(cls.library());
return lib.IsDebuggable();
@@ -2684,7 +2681,7 @@ RawError* Debugger::PauseStepping() {
// There is an "interesting frame" set. Only pause at appropriate
// locations in this frame.
if (IsCalleeFrameOf(stepping_fp_, frame->fp())) {
- // We are i n a callee of the frame we're interested in.
+ // We are in a callee of the frame we're interested in.
// Ignore this stepping break.
return Error::null();
} else if (IsCalleeFrameOf(frame->fp(), stepping_fp_)) {
@@ -2863,10 +2860,6 @@ void Debugger::PauseDeveloper(const String& msg) {
return;
}
- if (!NeedsDebugEvents()) {
- OS::Print("Hit debugger!");
- }
-
DebuggerStackTrace* stack_trace = CollectStackTrace();
ASSERT(stack_trace->Length() > 0);
ASSERT(stack_trace_ == NULL);
« no previous file with comments | « runtime/observatory/tests/service/set_library_debuggable_test.dart ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698