Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2361073002: [heap] Remove --print-cumulative-gc-stat flag. (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove --print-cumulative-gc-stat flag. The same information can be obtained by processing --trace-gc-nvp output or using trace event and GC metric of catapult in Chrome. BUG= Committed: https://crrev.com/74145159afdbb5274dc432842779002d39cc37ec Cr-Commit-Position: refs/heads/master@{#39780}

Patch Set 1 #

Patch Set 2 : unused variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -125 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.h View 2 chunks +0 lines, -33 lines 0 comments Download
M src/heap/gc-tracer.cc View 4 chunks +1 line, -8 lines 0 comments Download
M src/heap/heap.h View 2 chunks +1 line, -27 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +2 lines, -32 lines 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M src/heap/mark-compact.cc View 1 4 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
Hannes, ptal. Michael, Ali: fyi.
4 years, 2 months ago (2016-09-22 15:11:46 UTC) #2
Michael Lippautz
Cannot remember ever using this flag, so lgtm from my side.
4 years, 2 months ago (2016-09-26 11:09:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2361073002/20001
4 years, 2 months ago (2016-09-27 14:43:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 15:27:26 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 15:27:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74145159afdbb5274dc432842779002d39cc37ec
Cr-Commit-Position: refs/heads/master@{#39780}

Powered by Google App Engine
This is Rietveld 408576698