Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: src/heap/gc-tracer.h

Issue 2361073002: [heap] Remove --print-cumulative-gc-stat flag. (Closed)
Patch Set: unused variables Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | src/heap/gc-tracer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/gc-tracer.h
diff --git a/src/heap/gc-tracer.h b/src/heap/gc-tracer.h
index 5ef2b475a35489ec2d4848f32671d67f8ebc6699..120997fdfd30a991baa215aa06b8c5ae04823683 100644
--- a/src/heap/gc-tracer.h
+++ b/src/heap/gc-tracer.h
@@ -294,26 +294,6 @@ class GCTracer {
// Log an incremental marking step.
void AddIncrementalMarkingStep(double duration, intptr_t bytes);
- // Log time spent in marking.
- void AddMarkingTime(double duration) {
- cumulative_marking_duration_ += duration;
- }
-
- // Time spent in marking.
- double cumulative_marking_duration() const {
- return cumulative_marking_duration_;
- }
-
- // Log time spent in sweeping on main thread.
- void AddSweepingTime(double duration) {
- cumulative_sweeping_duration_ += duration;
- }
-
- // Time spent in sweeping on main thread.
- double cumulative_sweeping_duration() const {
- return cumulative_sweeping_duration_;
- }
-
// Compute the average incremental marking speed in bytes/millisecond.
// Returns 0 if no events have been recorded.
double IncrementalMarkingSpeedInBytesPerMillisecond() const;
@@ -462,24 +442,11 @@ class GCTracer {
// tracer.
double cumulative_pure_incremental_marking_duration_;
- // Total marking time.
- // This timer is precise when run with --print-cumulative-gc-stat
- double cumulative_marking_duration_;
-
// Incremental scopes carry more information than just the duration. The infos
// here are merged back upon starting/stopping the GC tracer.
IncrementalMarkingInfos
incremental_marking_scopes_[Scope::NUMBER_OF_INCREMENTAL_SCOPES];
- // Total sweeping time on the main thread.
- // This timer is precise when run with --print-cumulative-gc-stat
- // TODO(hpayer): Account for sweeping time on sweeper threads. Add a
- // different field for that.
- // TODO(hpayer): This timer right now just holds the sweeping time
- // of the initial atomic sweeping pause. Make sure that it accumulates
- // all sweeping operations performed on the main thread.
- double cumulative_sweeping_duration_;
-
double incremental_marking_start_time_;
// Timestamp and allocation counter at the last sampled allocation event.
« no previous file with comments | « src/flag-definitions.h ('k') | src/heap/gc-tracer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698