Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: src/type-feedback-vector-inl.h

Issue 2361043002: [Ignition] Use binary operation feedback from Ignition to Crankshaft. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/typing.cc ('k') | src/type-info.h » ('j') | src/type-info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/type-feedback-vector-inl.h
diff --git a/src/type-feedback-vector-inl.h b/src/type-feedback-vector-inl.h
index 4a1c01f1bc9fc096d1f3d2d1ee42220bf09c19f7..29e0ff74519da8d9b911ea78afe760c06370ea61 100644
--- a/src/type-feedback-vector-inl.h
+++ b/src/type-feedback-vector-inl.h
@@ -123,6 +123,8 @@ void TypeFeedbackVector::Set(FeedbackVectorSlot slot, Object* value,
// Helper function to transform the feedback to BinaryOperationHint.
BinaryOperationHint BinaryOperationHintFromFeedback(int type_feedback) {
switch (type_feedback) {
+ case BinaryOperationFeedback::kNone:
+ return BinaryOperationHint::kNone;
mythria 2016/09/22 14:09:42 Benedikt, I updated this function to pass None fee
Benedikt Meurer 2016/09/23 03:34:38 Yeah, this seems reasonable, defaulting to any is
case BinaryOperationFeedback::kSignedSmall:
return BinaryOperationHint::kSignedSmall;
case BinaryOperationFeedback::kNumber:
@@ -138,6 +140,8 @@ BinaryOperationHint BinaryOperationHintFromFeedback(int type_feedback) {
// Helper function to transform the feedback to CompareOperationHint.
CompareOperationHint CompareOperationHintFromFeedback(int type_feedback) {
switch (type_feedback) {
+ case CompareOperationFeedback::kNone:
+ return CompareOperationHint::kNone;
case CompareOperationFeedback::kSignedSmall:
return CompareOperationHint::kSignedSmall;
case CompareOperationFeedback::kNumber:
@@ -145,6 +149,8 @@ CompareOperationHint CompareOperationHintFromFeedback(int type_feedback) {
default:
return CompareOperationHint::kAny;
}
+ UNREACHABLE();
+ return CompareOperationHint::kNone;
}
void TypeFeedbackVector::ComputeCounts(int* with_type_info, int* generic,
« no previous file with comments | « src/crankshaft/typing.cc ('k') | src/type-info.h » ('j') | src/type-info.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698