[Ignition] Use binary operation feedback from Ignition to Crankshaft.

src/type-feedback-vector-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_TYPE_FEEDBACK_VECTOR_INL_H_
 #define V8_TYPE_FEEDBACK_VECTOR_INL_H_
 
 #include "src/globals.h"
 #include "src/type-feedback-vector.h"
 
@@ skipping 105 matching lines @@
 
 
 void TypeFeedbackVector::Set(FeedbackVectorSlot slot, Object* value,
                              WriteBarrierMode mode) {
   set(GetIndex(slot), value, mode);
 }
 
 // Helper function to transform the feedback to BinaryOperationHint.
 BinaryOperationHint BinaryOperationHintFromFeedback(int type_feedback) {
   switch (type_feedback) {
+    case BinaryOperationFeedback::kNone:
+      return BinaryOperationHint::kNone;

[mythria, 2016/09/22 14:09:42]

Benedikt, I updated this function to pass None feedback when the slot is
uninitialized instead of Any. I thought the earlier implementation of passing
BinaryOperationHint::kAny was not intentional.If so, let me know I will add a
comment explaining why.

[Benedikt Meurer, 2016/09/23 03:34:38]

Yeah, this seems reasonable, defaulting to any is not a good idea.

     case BinaryOperationFeedback::kSignedSmall:
       return BinaryOperationHint::kSignedSmall;
     case BinaryOperationFeedback::kNumber:
       return BinaryOperationHint::kNumberOrOddball;
     case BinaryOperationFeedback::kAny:
     default:
       return BinaryOperationHint::kAny;
   }
   UNREACHABLE();
   return BinaryOperationHint::kNone;
 }
 
 // Helper function to transform the feedback to CompareOperationHint.
 CompareOperationHint CompareOperationHintFromFeedback(int type_feedback) {
   switch (type_feedback) {
+    case CompareOperationFeedback::kNone:
+      return CompareOperationHint::kNone;
     case CompareOperationFeedback::kSignedSmall:
       return CompareOperationHint::kSignedSmall;
     case CompareOperationFeedback::kNumber:
       return CompareOperationHint::kNumber;
     default:
       return CompareOperationHint::kAny;
   }
+  UNREACHABLE();
+  return CompareOperationHint::kNone;
 }
 
 void TypeFeedbackVector::ComputeCounts(int* with_type_info, int* generic,
                                        bool code_is_interpreted) {
   Object* uninitialized_sentinel =
       TypeFeedbackVector::RawUninitializedSentinel(GetIsolate());
   Object* megamorphic_sentinel =
       *TypeFeedbackVector::MegamorphicSentinel(GetIsolate());
   int with = 0;
   int gen = 0;
@@ skipping 105 matching lines @@
   int index = vector()->GetIndex(slot()) + 1;
   vector()->set(index, feedback_extra, mode);
 }
 
 
 Isolate* FeedbackNexus::GetIsolate() const { return vector()->GetIsolate(); }
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TYPE_FEEDBACK_VECTOR_INL_H_