Chromium Code Reviews| Index: src/type-feedback-vector-inl.h |
| diff --git a/src/type-feedback-vector-inl.h b/src/type-feedback-vector-inl.h |
| index 4a1c01f1bc9fc096d1f3d2d1ee42220bf09c19f7..29e0ff74519da8d9b911ea78afe760c06370ea61 100644 |
| --- a/src/type-feedback-vector-inl.h |
| +++ b/src/type-feedback-vector-inl.h |
| @@ -123,6 +123,8 @@ void TypeFeedbackVector::Set(FeedbackVectorSlot slot, Object* value, |
| // Helper function to transform the feedback to BinaryOperationHint. |
| BinaryOperationHint BinaryOperationHintFromFeedback(int type_feedback) { |
| switch (type_feedback) { |
| + case BinaryOperationFeedback::kNone: |
| + return BinaryOperationHint::kNone; |
|
mythria
2016/09/22 14:09:42
Benedikt, I updated this function to pass None fee
Benedikt Meurer
2016/09/23 03:34:38
Yeah, this seems reasonable, defaulting to any is
|
| case BinaryOperationFeedback::kSignedSmall: |
| return BinaryOperationHint::kSignedSmall; |
| case BinaryOperationFeedback::kNumber: |
| @@ -138,6 +140,8 @@ BinaryOperationHint BinaryOperationHintFromFeedback(int type_feedback) { |
| // Helper function to transform the feedback to CompareOperationHint. |
| CompareOperationHint CompareOperationHintFromFeedback(int type_feedback) { |
| switch (type_feedback) { |
| + case CompareOperationFeedback::kNone: |
| + return CompareOperationHint::kNone; |
| case CompareOperationFeedback::kSignedSmall: |
| return CompareOperationHint::kSignedSmall; |
| case CompareOperationFeedback::kNumber: |
| @@ -145,6 +149,8 @@ CompareOperationHint CompareOperationHintFromFeedback(int type_feedback) { |
| default: |
| return CompareOperationHint::kAny; |
| } |
| + UNREACHABLE(); |
| + return CompareOperationHint::kNone; |
| } |
| void TypeFeedbackVector::ComputeCounts(int* with_type_info, int* generic, |