Issue 2360933003: [Merge-M54] arc: Use high-resolution icon for Play Store default item in app list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2360933003: [Merge-M54] arc: Use high-resolution icon for Play Store default item in app list. (Closed)

Created:
4 years, 3 months ago by khmel

Modified:
4 years, 3 months ago

Reviewers:
reviewer

CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, Matt Giuca

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Merge-M54] arc: Use high-resolution icon for Play Store default item in app list. BUG=648998 BUG=b/31596656 TEST=Manually on device. Painted icons different colors. 48x48 icon is used in shelf, 96x96 icon is used in app list. TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2358073002 Cr-Commit-Position: refs/heads/master@{#420093} (cherry picked from commit 878733d0c9eff7c0ac62070272159c967999f0d3)

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -5 lines)			Patch
M	chrome/browser/resources/chromeos/arc_support/icon/48.png	View	Binary file		0 comments	Download
A	chrome/browser/resources/chromeos/arc_support/icon/96.png	View	Binary file		0 comments	Download
M	chrome/browser/resources/chromeos/arc_support/manifest.json	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/component_extension_resources.grd	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/app_list/arc/arc_app_icon.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2360933003/1

4 years, 3 months ago (2016-09-22 17:38:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages