Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2358073002: arc: Use high-resolution icon for Play Store default item in app list. (Closed)

Created:
4 years, 3 months ago by khmel
Modified:
4 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, alemate+watch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Use high-resolution icon for Play Store default item in app list. BUG=648998 BUG=b/31596656 TEST=Manually on device. Painted icons different colors. 48x48 icon is used in shelf, 96x96 icon is used in app list. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/878733d0c9eff7c0ac62070272159c967999f0d3 Cr-Commit-Position: refs/heads/master@{#420093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/resources/chromeos/arc_support/icon/48.png View Binary file 0 comments Download
A chrome/browser/resources/chromeos/arc_support/icon/96.png View Binary file 0 comments Download
M chrome/browser/resources/chromeos/arc_support/manifest.json View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_icon.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
khmel
Hi Xiyuan, PTAL
4 years, 3 months ago (2016-09-21 16:30:08 UTC) #3
xiyuan
lgtm
4 years, 3 months ago (2016-09-21 16:41:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358073002/1
4 years, 3 months ago (2016-09-21 16:44:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 17:27:52 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 17:31:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/878733d0c9eff7c0ac62070272159c967999f0d3
Cr-Commit-Position: refs/heads/master@{#420093}

Powered by Google App Engine
This is Rietveld 408576698